fix(config): pass logLevel to rolldown during config bundling (fix #21971)#22021
Open
cyphercodes wants to merge 1 commit intovitejs:mainfrom
Open
fix(config): pass logLevel to rolldown during config bundling (fix #21971)#22021cyphercodes wants to merge 1 commit intovitejs:mainfrom
cyphercodes wants to merge 1 commit intovitejs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #21971 where
resolveConfig({ logLevel: 'silent' })was not suppressing Rolldown warnings during config file bundling.Problem
When using
resolveConfig({ logLevel: 'silent' }), Rolldown warnings were still being displayed during the config file bundling process. This happened because thelogLeveloption was not being passed to therolldown()call inbundleConfigFile.Solution
bundleConfigFileto accept an optionallogLevelparameterbundleAndLoadConfigFileto accept and forwardlogLevelloadConfigFromFileto passlogLevelto the bundlerlogLevelis now passed directly to therolldown()call, which respects the 'silent' settingChanges
packages/vite/src/node/config.ts: AddedlogLevelparameter tobundleConfigFileandbundleAndLoadConfigFile, passed it to therolldown()callTested locally by running the existing config tests - all 63 tests pass.