Skip to content

fix: prevent spurious rolling updates from revision serialization differences due to 1.34 API modification#798

Open
rudeigerc wants to merge 1 commit intokubernetes-sigs:mainfrom
rudeigerc:fix/spurious-rollout
Open

fix: prevent spurious rolling updates from revision serialization differences due to 1.34 API modification#798
rudeigerc wants to merge 1 commit intokubernetes-sigs:mainfrom
rudeigerc:fix/spurious-rollout

Conversation

@rudeigerc
Copy link
Copy Markdown

What type of PR is this?

/kind bug

What this PR does / why we need it

When upgrading the LWS controller across client-go versions, ControllerRevision.Data.Raw can change in semantically irrelevant ways. The existing EqualRevision performs a raw-bytes comparison and treats these differences as spec changes, causing getUpdatedRevision to trigger unnecessary rolling updates.

This PR adds a semantic equivalence check as a fallback when raw-bytes comparison fails, adapting the approach from kubernetes/kubernetes#135017 for the upstream StatefulSet controller.

Which issue(s) this PR fixes

Fixes #797

Special notes for your reviewer

Does this PR introduce a user-facing change?

Prevent spurious rolling updates from revision serialization differences due to 1.34 API modification.

/cc @Edwinhr716 @ahg-g @kerthcet

…ferences due to 1.34 API modification

Signed-off-by: rudeigerc <rudeigerc@gmail.com>
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 29, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 29, 2026

Deploy Preview for kubernetes-sigs-lws canceled.

Name Link
🔨 Latest commit 9c0155e
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-lws/deploys/69c8f218723cc500089b3d4d

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rudeigerc
Once this PR has been reviewed and has the lgtm label, please assign kerthcet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 29, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @rudeigerc!

It looks like this is your first PR to kubernetes-sigs/lws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/lws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 29, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @rudeigerc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 29, 2026
@Edwinhr716
Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 30, 2026
@rudeigerc
Copy link
Copy Markdown
Author

/test pull-lws-test-integration-main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spurious rolling updates from serialization differences in ControllerRevision after upgrading LWS to v0.8.0

3 participants