frontend: fix condition table column width#4967
Open
itvi-1234 wants to merge 1 commit intokubernetes-sigs:mainfrom
Open
frontend: fix condition table column width#4967itvi-1234 wants to merge 1 commit intokubernetes-sigs:mainfrom
itvi-1234 wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: itvi-1234 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
Contributor
|
Can you check the implications in other tables, to see if they get too wide? |
Contributor
Author
|
sure @joaquimrocha , I will 🚀 |
Contributor
Author
|
Hi @joaquimrocha , I have checked the tables , everything works fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a UI bug where long Kubernetes condition names (like PodReadyToStartContainers) were truncated in the Conditions table of resource details views. The fix ensures that the Condition column expands to accommodate the full name of the condition by using a min-content grid template.
Related Issue
Fixes #4966
Changes
frontend/src/components/common/Resource/Resource.tsx:1.Updated the ConditionsTable definition to support a gridTemplate property in its column configuration.
2.Set the gridTemplate to 'min-content' for the Condition column to prevent text truncation.
Steps to Test
1.Navigate to the Workloads -> Pods section and select a Pod.
2.Scroll down to the Conditions section at the bottom of the details page.
3.Observe the first column (Condition).
4.Verification: Confirm that long condition names (e.g., PodReadyToStartContainers) are fully visible and no longer cut off with ellipses.
Screenshots (if applicable)
Before:

After:
