Skip to content

UI: Make SimpleTable sorting icons match ResourceTable (#4944)#4952

Open
Utkarshpandey0001 wants to merge 4 commits intokubernetes-sigs:mainfrom
Utkarshpandey0001:fix-4944-simpletable-icons
Open

UI: Make SimpleTable sorting icons match ResourceTable (#4944)#4952
Utkarshpandey0001 wants to merge 4 commits intokubernetes-sigs:mainfrom
Utkarshpandey0001:fix-4944-simpletable-icons

Conversation

@Utkarshpandey0001
Copy link
Copy Markdown

This PR updates the sorting icons in the SimpleTable component to visually match the standard MUI arrow styling used natively by ResourceTable . It also introduces tooltips for the sorting buttons to improve accessibility and clarity, bringing it to full feature parity with the rest of the application.
Screenshot 2026-03-24 at 7 55 17 AM
Screenshot 2026-03-24 at 7 55 35 AM

…gs#4944)

Replaces the default menu-up and menu-down icons with arrow-up and arrow-down
to match the ResourceTable implementation. Adds tooltip to indicate action.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 24, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Utkarshpandey0001
Once this PR has been reviewed and has the lgtm label, please assign illume for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 24, 2026
Copy link
Copy Markdown
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there are some snapshots failing, can you check if those are related? you can see the errors locally with make frontend-test

@Utkarshpandey0001
Copy link
Copy Markdown
Author

@skoeva sure , let me check once and get back to u

@Utkarshpandey0001
Copy link
Copy Markdown
Author

@skoeva
Good catch, I ran make frontend-test and found that the visual snapshots were failing because of the new icons and tooltips. I've updated the snapshots to reflect the new UI changes. I also added the newly introduced swap-vertical icon to the offline cache registry (icons.ts) so that icons.test.ts passes correctly. Everything is green locally now.

@Utkarshpandey0001 Utkarshpandey0001 force-pushed the fix-4944-simpletable-icons branch from 1d1f0d1 to 9a00083 Compare March 24, 2026 13:41
@skoeva skoeva linked an issue Mar 25, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make sorting icon in SimpleTable match ResourceTable

3 participants