fix(frontend): handle cluster-scoped CRD links without failing on empty namespace#4935
Open
Utkarshpandey0001 wants to merge 1 commit intokubernetes-sigs:mainfrom
Open
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Utkarshpandey0001 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4921
This PR address issue #4921 where clicking the details link of a cluster-scoped custom resource (such as a ClusterVulnerabilityReport or other CVE-related plugins) crashed the UI with TypeError: Expected "namespace" to match "[^\/]+?", but received "".
The crashing behavior occurred because react-router requires all path parameters (like :namespace) to be non-empty, but cluster-scoped CRs naturally do not have a namespace. Attempting to use the customresource route fallback resulted in an empty parameter validation crash.
Changes made:
Added clusterCustomResource route in frontend/src/lib/router/index.tsx that explicitly omits the :namespace parameter (/customresources/:crd/:crName).
Updated Link Generation in CustomResourceList.tsx and CustomResourceInstancesList.tsx. It now dynamically checks if a namespace is present (cr.metadata.namespace). If it is, it uses the standard customresource route. If not, it uses the new clusterCustomResource route and omits the namespace param entirely.