Fix invalid body data when Content-Type is application/json#312
Open
ddbdzung wants to merge 1 commit intohoppscotch:mainfrom
Open
Fix invalid body data when Content-Type is application/json#312ddbdzung wants to merge 1 commit intohoppscotch:mainfrom
ddbdzung wants to merge 1 commit intohoppscotch:mainfrom
Conversation
Member
|
Hi @ddbdzung, this PR you raised is a good way to fix the serialization issue on the extension side, the current PR raised at the mono-repo around similar ser/de issue addresses several additional concerns including other interceptors and maintaining backwards compatibility. So please feel free to keep this PR open for future considerations. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Reference : #331 , #4861 , #4857
Problem
Axios requests with
Content-Type: application/jsonwere not properly serialized, causing incorrect payloads.Solution
JSON.stringify().Impact
✅ Fixes incorrect payload formatting.
✅ Ensures API compatibility.