Fix Tesla Fleet OAuth scope refresh during reauth#166920
Open
Bre77 wants to merge 1 commit intohome-assistant:devfrom
Open
Fix Tesla Fleet OAuth scope refresh during reauth#166920Bre77 wants to merge 1 commit intohome-assistant:devfrom
Bre77 wants to merge 1 commit intohome-assistant:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the prompt_missing_scopes: "true" parameter to Tesla Fleet OAuth authorization requests to enable reauthentication to refresh newly enabled Tesla API scopes. It also updates user-facing documentation to explain the reauthentication mechanism and adds corresponding test coverage.
Changes:
- Added
prompt_missing_scopes: "true"OAuth parameter to the authorization request inoauth.pyto allow users to grant additional scopes during reauthentication - Updated config flow strings to explain that reauthentication refreshes granted scopes, including newly enabled ones
- Extended config flow tests to assert the presence of the new
prompt_missing_scopesparameter
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/components/tesla_fleet/oauth.py | Added prompt_missing_scopes parameter to OAuth extra_authorize_data |
| homeassistant/components/tesla_fleet/strings.json | Updated user documentation explaining scope refresh during reauth |
| tests/components/tesla_fleet/test_config_flow.py | Added assertion verifying the prompt_missing_scopes parameter in OAuth URL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add
prompt_missing_scopes=trueto Tesla Fleet OAuth authorization requests so reauthentication can refresh newly enabled Tesla API scopes instead of silently reusing an older grant. Update the Tesla Fleet config-flow copy to explain that reauthentication refreshes granted scopes and that users should reauthenticate after enabling additional Tesla API permissions. Extend the config-flow test to assert the new authorization parameter.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: