Fix Tesla Fleet charge current scope handling#166919
Open
Bre77 wants to merge 1 commit intohome-assistant:devfrom
Open
Fix Tesla Fleet charge current scope handling#166919Bre77 wants to merge 1 commit intohome-assistant:devfrom
Bre77 wants to merge 1 commit intohome-assistant:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes the Tesla Fleet charge_state_charge_current_request number entity to accept either VEHICLE_CHARGING_CMDS or VEHICLE_CMDS scopes, matching the behavior of the set_charging_amps API command and preventing the entity from being incorrectly treated as read-only when an application has the broader VEHICLE_CMDS scope.
Changes:
- Updated the
charge_state_charge_current_requestentity scopes to include bothVEHICLE_CHARGING_CMDSandVEHICLE_CMDS, making it consistent with thecharge_state_charge_limit_socentity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Correct the Tesla Fleet
charge_state_charge_current_requestnumber entity to use eithervehicle_charging_cmdsorvehicle_cmds.https://developer.tesla.com/docs/fleet-api/endpoints/vehicle-commands#set-charging-amps
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: