Register trigger platform upon use#166911
Open
arturpragacz wants to merge 1 commit intohome-assistant:devfrom
Open
Register trigger platform upon use#166911arturpragacz wants to merge 1 commit intohome-assistant:devfrom
arturpragacz wants to merge 1 commit intohome-assistant:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures trigger platforms are registered when a trigger is first used, so the trigger-description system can discover and load the corresponding triggers.yaml metadata.
Changes:
- Register the trigger platform from within
_async_get_trigger_platform()to populatehass.data[TRIGGERS]on-demand. - Make
_register_trigger_platform()idempotent to avoid re-registering existing triggers and to reduce misleading debug logs. - Add a test covering trigger registration and subscriber notification behavior when a trigger platform is first accessed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
homeassistant/helpers/trigger.py |
Registers trigger platforms on-demand and makes platform registration idempotent. |
tests/helpers/test_trigger.py |
Adds coverage verifying registration side effects and subscriber notifications. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Register trigger platform upon use.
When a trigger is used, register its platform to make trigger descriptions available.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: