Set up todo frontend resources when first platform is set up#166878
Draft
emontnemery wants to merge 1 commit intodevfrom
Draft
Set up todo frontend resources when first platform is set up#166878emontnemery wants to merge 1 commit intodevfrom
emontnemery wants to merge 1 commit intodevfrom
Conversation
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR delays registering the Todo built-in frontend panel and Todo WebSocket commands until a Todo platform/config entry is actually set up, so the Todo panel is not exposed when there are no Todo platforms.
Changes:
- Move Todo frontend panel + WebSocket command registration out of
async_setupand into a newTodoEntityComponentthat registers them on first platform/config-entry setup. - Add tests asserting frontend/WebSocket resources are only registered after the first platform/config entry is set up.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
homeassistant/components/todo/__init__.py |
Introduces TodoEntityComponent to lazily register the Todo panel/WebSocket commands after first platform/entry setup. |
tests/components/todo/test_init.py |
Adds coverage for when the Todo panel/WebSocket commands become registered. |
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Set up todo frontend resources when first todo platform is set up to prevent loading the todo panel when there are no todo platforms
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: