Add Scaleway Object Storage backup integration by BjoernPetersen · Pull Request #166868 · home-assistant/core

BjoernPetersen · 2026-03-30T12:06:11Z

Proposed change

This PR adds a new Scaleway Object Storage integration that allows users to store Home Assistant backups in Scaleway Object Storage.

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

No AI tools were used to create this PR (except for the Copilot PR review over here).

I choose the aiohttp-s3-client package as a dependency because - other than aiobotocore - it's a fully async dependendency and offers type hints without a separate stub package.

I plan to add further improvements and achieve a higher ranking on the quality scale in the future. This PR just adds what I consider a "basic" feature set.

Link to documentation pull request: Add docs for Scaleway Object Storage home-assistant.io#44397
Link to brands repository pull request: Add assets for Scaleway Object Storage brands#10056

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.
Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io
- Pending: Add docs for Scaleway Object Storage home-assistant.io#44397

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
(not applicable) For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant

Hi @BjoernPetersen

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copilot

Pull request overview

Adds a new Home Assistant integration to store backups in Scaleway Object Storage, including config flow support and initial test coverage.

Changes:

Introduces scaleway_object_storage integration (config flow, backup agent, exceptions, translations, quality scale metadata).
Adds config flow tests (user / reauth / reconfigure) and shared fixtures.
Registers dependency (aiohttp-s3-client), code ownership, strict typing, and generated registry updates.

Reviewed changes

Copilot reviewed 19 out of 21 changed files in this pull request and generated 19 comments.

Show a summary per file

File	Description
tests/components/scaleway_object_storage/test_config_flow_step_user.py	Adds user-step config flow tests.
tests/components/scaleway_object_storage/test_config_flow_step_reconfigure.py	Adds reconfigure-step config flow tests.
tests/components/scaleway_object_storage/test_config_flow_step_reauth.py	Adds reauth-step config flow tests.
tests/components/scaleway_object_storage/conftest.py	Adds shared fixtures for Scaleway Object Storage tests.
tests/components/scaleway_object_storage/init.py	Initializes the test package.
requirements_test_all.txt	Adds `aiohttp-s3-client` to test requirements.
requirements_all.txt	Adds `aiohttp-s3-client` to runtime requirements.
mypy.ini	Enables strict mypy settings for the new integration package.
homeassistant/generated/integrations.json	Registers the new integration in generated metadata.
homeassistant/generated/config_flows.py	Adds the integration domain to generated config flow registry.
homeassistant/components/scaleway_object_storage/strings.json	Adds config flow text, selector options, and exception translations.
homeassistant/components/scaleway_object_storage/quality_scale.yaml	Declares quality scale compliance status for the integration.
homeassistant/components/scaleway_object_storage/manifest.json	Defines integration metadata and dependency requirements.
homeassistant/components/scaleway_object_storage/helpers.py	Adds S3 client creation, connection check, and metadata read helpers.
homeassistant/components/scaleway_object_storage/exceptions.py	Adds translated, typed exception hierarchy for config/runtime errors.
homeassistant/components/scaleway_object_storage/const.py	Adds integration constants (config keys, limits, headers).
homeassistant/components/scaleway_object_storage/config_flow.py	Implements user / reauth / reconfigure config flow steps.
homeassistant/components/scaleway_object_storage/backup.py	Implements BackupAgent against Scaleway S3-compatible object storage.
homeassistant/components/scaleway_object_storage/init.py	Sets up the config entry and wires runtime client creation.
CODEOWNERS	Assigns ownership for the new integration and its tests.
.strict-typing	Marks the new integration for strict typing enforcement.

homeassistant/components/scaleway_object_storage/__init__.py

homeassistant/components/scaleway_object_storage/helpers.py

homeassistant/components/scaleway_object_storage/backup.py

homeassistant/components/scaleway_object_storage/helpers.py

homeassistant/components/scaleway_object_storage/config_flow.py

Copilot

Pull request overview

Copilot reviewed 19 out of 21 changed files in this pull request and generated 9 comments.

homeassistant/components/scaleway_object_storage/backup.py

homeassistant/components/scaleway_object_storage/config_flow.py

homeassistant/components/scaleway_object_storage/backup.py

homeassistant/components/scaleway_object_storage/helpers.py

homeassistant/components/scaleway_object_storage/config_flow.py

homeassistant/components/scaleway_object_storage/__init__.py

Copilot

Pull request overview

Copilot reviewed 19 out of 21 changed files in this pull request and generated 4 comments.

homeassistant/components/scaleway_object_storage/helpers.py

tests/components/scaleway_object_storage/conftest.py

homeassistant/components/scaleway_object_storage/backup.py

Copilot

Pull request overview

Copilot reviewed 19 out of 21 changed files in this pull request and generated 6 comments.

tests/components/scaleway_object_storage/test_config_flow_step_user.py

homeassistant/components/scaleway_object_storage/exceptions.py

homeassistant/components/scaleway_object_storage/helpers.py

homeassistant/components/scaleway_object_storage/backup.py

Copilot

Pull request overview

Copilot reviewed 19 out of 21 changed files in this pull request and generated 9 comments.

homeassistant/components/scaleway_object_storage/backup.py

homeassistant/components/scaleway_object_storage/helpers.py

homeassistant/components/scaleway_object_storage/backup.py

homeassistant/components/scaleway_object_storage/helpers.py

homeassistant/components/scaleway_object_storage/config_flow.py

Copilot

Pull request overview

Copilot reviewed 19 out of 21 changed files in this pull request and generated 2 comments.

homeassistant/components/scaleway_object_storage/backup.py

Copilot

Pull request overview

Copilot reviewed 19 out of 21 changed files in this pull request and generated 21 comments.

Copilot · 2026-03-30T17:30:59Z

homeassistant/components/scaleway_object_storage/helpers.py

@@ -0,0 +1,165 @@
+"""Integration-internal helper functions that bundle common interactions with the underlying aiohttp_s3_client."""
+


This module uses Mapping, AsyncGenerator, and Generator in runtime type annotations, but they are only imported under TYPE_CHECKING. Without from __future__ import annotations, this can raise NameError at import time. Fix by adding from __future__ import annotations at the top, or by importing these types unconditionally (outside TYPE_CHECKING).

Suggested change

from __future__ import annotations

Copilot · 2026-03-30T17:30:59Z

homeassistant/components/scaleway_object_storage/helpers.py

+from http import HTTPStatus
+import json
+import logging
+from typing import TYPE_CHECKING, Any


This module uses Mapping, AsyncGenerator, and Generator in runtime type annotations, but they are only imported under TYPE_CHECKING. Without from __future__ import annotations, this can raise NameError at import time. Fix by adding from __future__ import annotations at the top, or by importing these types unconditionally (outside TYPE_CHECKING).

Copilot · 2026-03-30T17:31:00Z

homeassistant/components/scaleway_object_storage/helpers.py

+if TYPE_CHECKING:
+    from collections.abc import AsyncGenerator, Generator, Mapping


This module uses Mapping, AsyncGenerator, and Generator in runtime type annotations, but they are only imported under TYPE_CHECKING. Without from __future__ import annotations, this can raise NameError at import time. Fix by adding from __future__ import annotations at the top, or by importing these types unconditionally (outside TYPE_CHECKING).

Suggested change

if TYPE_CHECKING:

from collections.abc import AsyncGenerator, Generator, Mapping

from collections.abc import AsyncGenerator, Generator, Mapping

Copilot · 2026-03-30T17:31:00Z

homeassistant/components/scaleway_object_storage/config_flow.py

@@ -0,0 +1,204 @@
+"""Config flow for the Scaleway Object Storage integration."""


ConfigFlowResult is referenced in return annotations but only imported under TYPE_CHECKING. Without postponed annotation evaluation, this can raise NameError at import time. Add from __future__ import annotations or import ConfigFlowResult at runtime.

Suggested change

"""Config flow for the Scaleway Object Storage integration."""

"""Config flow for the Scaleway Object Storage integration."""

from __future__ import annotations

Copilot · 2026-03-30T17:31:00Z

homeassistant/components/scaleway_object_storage/config_flow.py

+if TYPE_CHECKING:
+    from homeassistant.config_entries import ConfigFlowResult


ConfigFlowResult is referenced in return annotations but only imported under TYPE_CHECKING. Without postponed annotation evaluation, this can raise NameError at import time. Add from __future__ import annotations or import ConfigFlowResult at runtime.

tests/components/scaleway_object_storage/test_config_flow_step_reauth.py

Copilot · 2026-03-30T17:31:03Z

homeassistant/components/scaleway_object_storage/__init__.py

+
+    # Notify backup listeners
+    def notify_backup_listeners() -> None:
+        for listener in hass.data.get(DATA_BACKUP_AGENT_LISTENERS, []):


Iterating over the listeners list directly can break if a listener unregisters itself (or another listener) during callback execution, mutating the list while iterating. Iterate over a shallow copy (e.g., for listener in list(...):) to make this robust.

Suggested change

for listener in hass.data.get(DATA_BACKUP_AGENT_LISTENERS, []):

for listener in list(hass.data.get(DATA_BACKUP_AGENT_LISTENERS, [])):

Copilot · 2026-03-30T17:31:03Z

homeassistant/components/scaleway_object_storage/backup.py

+
+        return self._yield_chunks(response)
+
+    async def async_upload_backup(


The PR adds substantial new BackupAgent behavior (download/upload/list/get/delete, multipart uploads, error handling, and reauth triggering) but the added tests cover only config flows. Add tests for the backup agent methods (at least: async_list_backups success + ignored-object behavior, async_download_backup response cleanup on errors, and upload paths single vs multipart) to prevent regressions.

Copilot · 2026-03-30T17:31:03Z

homeassistant/components/scaleway_object_storage/backup.py

@@ -0,0 +1,424 @@
+"""BackupAgent implementation based on Scaleway Object Storage."""
+


The PR adds substantial new BackupAgent behavior (download/upload/list/get/delete, multipart uploads, error handling, and reauth triggering) but the added tests cover only config flows. Add tests for the backup agent methods (at least: async_list_backups success + ignored-object behavior, async_download_backup response cleanup on errors, and upload paths single vs multipart) to prevent regressions.

Copilot · 2026-03-30T17:31:04Z

homeassistant/components/scaleway_object_storage/backup.py

+        # Get task results and filter out None values
+        return list(filter(None, (task.result() for task in backups)))
+
+    async def async_get_backup(self, backup_id: str, **kwargs: Any) -> AgentBackup:


The PR adds substantial new BackupAgent behavior (download/upload/list/get/delete, multipart uploads, error handling, and reauth triggering) but the added tests cover only config flows. Add tests for the backup agent methods (at least: async_list_backups success + ignored-object behavior, async_download_backup response cleanup on errors, and upload paths single vs multipart) to prevent regressions.

Copilot AI review requested due to automatic review settings March 30, 2026 12:06

home-assistant bot added cla-needed has-tests new-integration labels Mar 30, 2026

home-assistant bot requested changes Mar 30, 2026

View reviewed changes

home-assistant bot added integration: scaleway_object_storage quality-scale labels Mar 30, 2026

This was referenced Mar 30, 2026

Add docs for Scaleway Object Storage home-assistant/home-assistant.io#44397

Open

Add assets for Scaleway Object Storage home-assistant/brands#10056

Open

Copilot started reviewing on behalf of BjoernPetersen March 30, 2026 12:06 View session

home-assistant bot added cla-recheck cla-signed and removed cla-recheck cla-needed labels Mar 30, 2026

Copilot AI reviewed Mar 30, 2026

View reviewed changes

BjoernPetersen force-pushed the scaleway-object-storage branch 2 times, most recently from 24c5809 to 0cd40e8 Compare March 30, 2026 12:25

Copilot AI review requested due to automatic review settings March 30, 2026 12:25

Copilot started reviewing on behalf of BjoernPetersen March 30, 2026 12:26 View session

BjoernPetersen force-pushed the scaleway-object-storage branch 2 times, most recently from cffb3f4 to f30177a Compare March 30, 2026 12:34

Copilot AI reviewed Mar 30, 2026

View reviewed changes

BjoernPetersen force-pushed the scaleway-object-storage branch from f30177a to c3bf285 Compare March 30, 2026 12:36

Copilot AI review requested due to automatic review settings March 30, 2026 12:44

Copilot started reviewing on behalf of BjoernPetersen March 30, 2026 12:45 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

BjoernPetersen force-pushed the scaleway-object-storage branch from 3b5b5e8 to d6972ae Compare March 30, 2026 13:19

Copilot AI review requested due to automatic review settings March 30, 2026 14:01

BjoernPetersen force-pushed the scaleway-object-storage branch from d6972ae to b3830b6 Compare March 30, 2026 14:01

Copilot started reviewing on behalf of BjoernPetersen March 30, 2026 14:02 View session

BjoernPetersen force-pushed the scaleway-object-storage branch from b3830b6 to 9e2d0b5 Compare March 30, 2026 14:12

Copilot AI reviewed Mar 30, 2026

View reviewed changes

BjoernPetersen force-pushed the scaleway-object-storage branch from 9e2d0b5 to aa362de Compare March 30, 2026 14:27

Copilot AI review requested due to automatic review settings March 30, 2026 14:38

BjoernPetersen force-pushed the scaleway-object-storage branch from aa362de to 3e55dcb Compare March 30, 2026 14:38

Copilot started reviewing on behalf of BjoernPetersen March 30, 2026 14:39 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

BjoernPetersen force-pushed the scaleway-object-storage branch from 3e55dcb to 93ead40 Compare March 30, 2026 15:08

Copilot AI review requested due to automatic review settings March 30, 2026 15:39

BjoernPetersen force-pushed the scaleway-object-storage branch from 93ead40 to bb1dc56 Compare March 30, 2026 15:39

Copilot started reviewing on behalf of BjoernPetersen March 30, 2026 15:40 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

homeassistant/components/scaleway_object_storage/backup.py Show resolved Hide resolved

homeassistant/components/scaleway_object_storage/backup.py Show resolved Hide resolved

BjoernPetersen force-pushed the scaleway-object-storage branch from bb1dc56 to 30ee6c2 Compare March 30, 2026 16:42

Copilot AI review requested due to automatic review settings March 30, 2026 17:18

BjoernPetersen force-pushed the scaleway-object-storage branch from 30ee6c2 to 02045f0 Compare March 30, 2026 17:18

Copilot started reviewing on behalf of BjoernPetersen March 30, 2026 17:18 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

Add Scaleway Object Storage backup integration

ebd4df2

BjoernPetersen force-pushed the scaleway-object-storage branch from 02045f0 to ebd4df2 Compare March 30, 2026 17:45

		@@ -0,0 +1,165 @@
		"""Integration-internal helper functions that bundle common interactions with the underlying aiohttp_s3_client."""

		if TYPE_CHECKING:
		from collections.abc import AsyncGenerator, Generator, Mapping

		@@ -0,0 +1,204 @@
		"""Config flow for the Scaleway Object Storage integration."""

	"""Config flow for the Scaleway Object Storage integration."""
	"""Config flow for the Scaleway Object Storage integration."""
	from __future__ import annotations

		if TYPE_CHECKING:
		from homeassistant.config_entries import ConfigFlowResult

	for listener in hass.data.get(DATA_BACKUP_AGENT_LISTENERS, []):
	for listener in list(hass.data.get(DATA_BACKUP_AGENT_LISTENERS, [])):


		return self._yield_chunks(response)

		async def async_upload_backup(

		@@ -0,0 +1,424 @@
		"""BackupAgent implementation based on Scaleway Object Storage."""

Uh oh!

Conversation

BjoernPetersen commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

BjoernPetersen commented Mar 30, 2026 •

edited

Loading