Define CommandMessage pattern and implement first messages#6640
Draft
Define CommandMessage pattern and implement first messages#6640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Come up with a pattern to define with a strong type the Commands that we send to the frontend that uses the
commandJSON discriminator. Since a sealed class member cannot have twice the same discriminator (otherwise it cannot de-serialize properly), I had to come up with this pattern where we override theinvokeoperator of an object to keep a nice API.Checklist
Any other notes
I don't like it but I didn't find any other way for the Payload to be a JsonElement, using a template breaks the serialization engine.