Progress bar customization by inukiwi · Pull Request #6527 · home-assistant/android

inukiwi · 2026-03-03T14:01:09Z

Summary

This feature adds support for progress bar customization on Android 16.0+ devices, as shown here.

Checklist

New or updated tests have been added to cover the changes following the testing guidelines.
The code follows the project's code style and best_practices.
The changes have been thoroughly tested, and edge cases have been considered.
Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

Screenshots

Link to pull request in documentation repositories

User Documentation: home-assistant/companion.home-assistant#1297

Any other notes

app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt

Copilot

Pull request overview

Adds support for Android 16+ “progress-centric” notification customization in the Android Companion App notification pipeline, enabling richer progress rendering (segments/points and custom icons) when notifications are received from Home Assistant.

Changes:

Added parsing helper (parseFlattenedList) to interpret flattened list payloads (e.g., from WebSocket-flattened notification data)
Added Android 16+ NotificationCompat.ProgressStyle handling for segments, points, and tracker/start/end icons
Introduced new notification data keys for progress customization (progress_segments, progress_points, progress_*_icon, progress_*_color)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
common/src/main/kotlin/io/homeassistant/companion/android/common/notifications/NotificationFunctions.kt	Adds helper to parse flattened list strings into structured key/value maps for progress style inputs
app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt	Applies Android 16+ progress-centric `ProgressStyle` based on new notification payload keys

You can also share your feedback on Copilot code review. Take the survey.

app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt

Copilot · 2026-03-06T12:04:26Z

...main/kotlin/io/homeassistant/companion/android/common/notifications/NotificationFunctions.kt

+    try {
+        val list: List<Map<String, String>> = flattenedList
+            .trim()
+            .removeSurrounding("[", "]")
+            .split("}, {")
+            .map { segment ->
+                segment.trim().removePrefix("{").removeSuffix("}")
+                    .split(",")
+                    .associate { pair ->
+                        val (key, value) = pair.split("=")
+                        key.trim() to value.trim()
+                    }
+            }
+        return list
+    } catch (e: Exception) {
+        Timber.tag(NotificationData.TAG).e(e, "Unable to parse flattened list")
+        return emptyList()


parseFlattenedList will throw (and log an error) for valid inputs like an empty list ("[]"), because after removeSurrounding the string becomes blank and the code still tries to parse key/value pairs. It is also brittle for minor formatting differences (e.g., missing spaces between elements) and for values containing =.

Consider handling blank/empty lists explicitly (return empty without logging), splitting map entries more defensively (e.g., split("=", limit = 2)), and using a separator regex like "}\s*,\s*{" so spacing differences do not break parsing.

Suggested change

try {

val list: List<Map<String, String>> = flattenedList

.trim()

.removeSurrounding("[", "]")

.split("}, {")

.map { segment ->

segment.trim().removePrefix("{").removeSuffix("}")

.split(",")

.associate { pair ->

val (key, value) = pair.split("=")

key.trim() to value.trim()

}

}

return list

} catch (e: Exception) {

Timber.tag(NotificationData.TAG).e(e, "Unable to parse flattened list")

return emptyList()

val content = flattenedList

.trim()

.removeSurrounding("[", "]")

.trim()

if (content.isBlank()) {

// Treat an empty or whitespace-only list as a valid empty result

return emptyList()

}

return try {

val segmentSeparator = Regex("\\}\\s*,\\s*\\{")

content

.split(segmentSeparator)

.map { segment ->

val normalizedSegment = segment

.trim()

.removePrefix("{")

.removeSuffix("}")

.trim()

if (normalizedSegment.isBlank()) {

emptyMap()

} else {

normalizedSegment

.split(Regex("\\s*,\\s*"))

.filter { it.isNotBlank() }

.associate { pair ->

val parts = pair.split("=", limit = 2)

val key = parts.getOrNull(0)?.trim().orEmpty()

val value = parts.getOrNull(1)?.trim().orEmpty()

key to value

}

}

}

} catch (e: Exception) {

Timber.tag(NotificationData.TAG).e(e, "Unable to parse flattened list")

emptyList()

I opted for a minimal method here that only handles valid lists with a depth of 1 and defaults to an empty list.

If we want this method to be used in the future for other purposes I can also rewrite it into a recursive method that handles all nested objects/lists

If you make it public, you need to write down the limitations.

TimoPtr · 2026-03-23T13:45:09Z

...main/kotlin/io/homeassistant/companion/android/common/notifications/NotificationFunctions.kt

    builder.setDeleteIntent(deletePendingIntent)
 }
+
+fun parseFlattenedList(flattenedList: String): List<Map<String, String>> {


This function is quite specific no? It is a public function it's quite bad to expose it to the rest of the app, what would you think if you were proposed this function by the IDE without knowing the internal and where it can be used?

I would also this to be documented with examples.

TimoPtr · 2026-03-23T13:45:34Z

...main/kotlin/io/homeassistant/companion/android/common/notifications/NotificationFunctions.kt

+                    }
+            }
+        return list
+    } catch (e: Exception) {


The error catching is too broad can you identify what can throw and only catch this?

TimoPtr · 2026-03-23T13:52:03Z

app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt

+                sizeDp = 20
+                colorFilter = PorterDuffColorFilter(progressTrackerColor, PorterDuff.Mode.SRC_IN)
+                backgroundColorRes = accentColor
+                roundedCornersDp = 10
+                paddingDp = 4
+            }


I would like some docs about the choice of these magic numbers.

TimoPtr · 2026-03-23T13:52:19Z

app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt

+        if (progressStartIcon.startsWith("mdi:") && progressStartIcon.substringAfter("mdi:").isNotBlank()) {
+            val iconName = progressStartIcon.split(":")[1]
+            val iconDrawable = IconicsDrawable(context, "cmd-$iconName").apply {
+                sizeDp = 20


same here or even a const

TimoPtr · 2026-03-23T13:52:23Z

app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt

+        if (progressEndIcon.startsWith("mdi:") && progressEndIcon.substringAfter("mdi:").isNotBlank()) {
+            val iconName = progressEndIcon.split(":")[1]
+            val iconDrawable = IconicsDrawable(context, "cmd-$iconName").apply {
+                sizeDp = 20


same here or even a const

TimoPtr · 2026-03-23T13:59:11Z

app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt

+        if (progressTrackerIcon.startsWith("mdi:") && progressTrackerIcon.substringAfter("mdi:").isNotBlank()) {
+            val iconName = progressTrackerIcon.split(":")[1]


Just to be on the safe side we might want to verify the size while doing the split.

isNotBlank() already suggests the size is at least 1 non-whitespace character though, and user input means incorrect icon names need to be handled anyway (below with != null after trying)

TimoPtr · 2026-03-23T13:59:35Z

app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt

+        if (progressStartIcon.startsWith("mdi:") && progressStartIcon.substringAfter("mdi:").isNotBlank()) {
+            val iconName = progressStartIcon.split(":")[1]


same and could actually be wrap into a small helper

TimoPtr · 2026-03-23T13:59:47Z

app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt

+        if (progressEndIcon.startsWith("mdi:") && progressEndIcon.substringAfter("mdi:").isNotBlank()) {
+            val iconName = progressEndIcon.split(":")[1]


inukiwi and others added 3 commits March 3, 2026 13:49

Add support for progress styling on Android 16+

bfb5e9a

Merge branch 'home-assistant:main' into progress_style_notifications

90f98e9

Fix check on wrong progress bar icon

58d3bd8

home-assistant bot added the cla-signed label Mar 3, 2026

inukiwi mentioned this pull request Mar 3, 2026

Add documentation for progress bar customization on Android home-assistant/companion.home-assistant#1297

Open

7 tasks

TimoPtr reviewed Mar 5, 2026

View reviewed changes

app/src/main/kotlin/io/homeassistant/companion/android/notifications/MessagingManager.kt Show resolved Hide resolved

inukiwi added 2 commits March 5, 2026 14:22

Refactor progress bar customization into separate methods

468a3b9

Handle non-numeric values in progress segments and points

d66ece6

inukiwi marked this pull request as ready for review March 6, 2026 11:59

Copilot AI review requested due to automatic review settings March 6, 2026 11:59

Copilot started reviewing on behalf of inukiwi March 6, 2026 12:00 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

Fix fallback to theme accent color if dynamic accent color is not found

793f63e

TimoPtr reviewed Mar 23, 2026

View reviewed changes

TimoPtr marked this pull request as draft March 23, 2026 13:59

		if (progressTrackerIcon.startsWith("mdi:") && progressTrackerIcon.substringAfter("mdi:").isNotBlank()) {
		val iconName = progressTrackerIcon.split(":")[1]

		if (progressStartIcon.startsWith("mdi:") && progressStartIcon.substringAfter("mdi:").isNotBlank()) {
		val iconName = progressStartIcon.split(":")[1]

		if (progressEndIcon.startsWith("mdi:") && progressEndIcon.substringAfter("mdi:").isNotBlank()) {
		val iconName = progressEndIcon.split(":")[1]

Uh oh!

Conversation

inukiwi commented Mar 3, 2026

Summary

Checklist

Screenshots

Link to pull request in documentation repositories

Any other notes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants