Move pollyfills for !NET targets to src/libraries/Common/src/Polyfills/ by EgorBo · Pull Request #126287 · dotnet/runtime

EgorBo · 2026-03-30T01:54:46Z

This allows us to pretend new APIs exist for .NET Standard 2.0/NETFX/etc targets and avoid #if NET else mess.

…e IsFinite - Revert OperatingSystem.Is* polyfills (keep #if NET guards) - Replace more 0x7FFFFFC7 constants with Array.MaxLength via polyfill (FrozenHashTable 2nd occurrence, CborWriter, JsonDocument.MetadataDb) - Inline JsonHelpers.IsFinite into call sites (double.IsFinite/float.IsFinite) - Inline Base2ExponentialHistogramAggregator.IsFinite into call sites Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Split into IReadOnlySetPolyfill.cs and BitOperationsPolyfill.cs. Both use #if !NET guards since the types don't exist on downlevel. Update both src and test csproj references. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Split into BitConverterPolyfills.cs and GuidPolyfills.cs for reuse across libraries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dotnet-policy-service · 2026-03-30T01:56:04Z

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

Moves downlevel polyfills into src/libraries/Common/src/Polyfills/ and updates multiple libraries to call the “modern” APIs unconditionally (e.g., Stopwatch.GetElapsedTime, double.IsFinite, Array.MaxLength), relying on polyfills for non-.NETCoreApp targets to reduce #if usage.

Changes:

Replaced many #if NET / #else code paths with unified API calls and added corresponding polyfills via $(CommonPath)Polyfills\*.cs.
Removed library-local polyfill helpers (e.g., JsonHelpers.IsFinite, System.Collections.Immutable’s System/Polyfills.cs) in favor of shared Common polyfills.
Updated project files to link in the required polyfill sources for non-.NETCoreApp target frameworks.

Reviewed changes

Copilot reviewed 45 out of 45 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/libraries/System.Threading.RateLimiting/src/System/Threading/RateLimiting/RateLimiterHelper.cs	Uses `Stopwatch.GetElapsedTime` unconditionally (polyfilled for downlevel).
src/libraries/System.Threading.RateLimiting/src/System.Threading.RateLimiting.csproj	Links `StopwatchPolyfills.cs` for non-`.NETCoreApp` builds.
src/libraries/System.Text.Json/src/System/Text/Json/Writer/JsonWriterHelper.cs	Switches finite checks to `double.IsFinite` / `float.IsFinite`.
src/libraries/System.Text.Json/src/System/Text/Json/Reader/Utf8JsonReader.TryGet.cs	Switches finite checks to `double.IsFinite` / `float.IsFinite`.
src/libraries/System.Text.Json/src/System/Text/Json/JsonHelpers.cs	Removes local `IsFinite` helpers and `BitArray.HasAllSet` polyfill.
src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonDocument.MetadataDb.cs	Uses `Array.MaxLength` instead of hardcoded constant.
src/libraries/System.Text.Json/src/System.Text.Json.csproj	Links Double/Single/BitArray/Array polyfills for non-`.NETCoreApp`.
src/libraries/System.Speech/src/System.Speech.csproj	Links `StreamPolyfills.cs` for non-`.NETCoreApp`.
src/libraries/System.Speech/src/Internal/Synthesis/EngineSite.cs	Replaces manual read loop with `Stream.ReadExactly`.
src/libraries/System.Speech/src/Internal/Synthesis/AudioBase.cs	Replaces manual read loop with `Stream.ReadExactly`.
src/libraries/System.Reflection.Metadata/src/System.Reflection.Metadata.csproj	Replaces in-project polyfills with linked Common `BitConverter`/`Guid` polyfills.
src/libraries/System.IO.Hashing/src/System/IO/Hashing/NonCryptographicHashAlgorithm.cs	Uses `CopyToAsync(destination, cancellationToken)` overload unconditionally (polyfilled downlevel).
src/libraries/System.IO.Hashing/src/System.IO.Hashing.csproj	Links `StreamPolyfills.cs` for non-`.NETCoreApp`.
src/libraries/System.Formats.Cbor/src/System/Formats/Cbor/Writer/CborWriter.cs	Uses `Array.MaxLength` unconditionally.
src/libraries/System.Formats.Cbor/src/System/Formats/Cbor/Writer/CborWriter.Tag.cs	Uses `DateTimeOffset.TotalOffsetMinutes` unconditionally (polyfilled downlevel).
src/libraries/System.Formats.Cbor/src/System/Formats/Cbor/CborConformanceLevel.cs	Uses `HashCode.AddBytes` unconditionally (polyfilled downlevel).
src/libraries/System.Formats.Cbor/src/System.Formats.Cbor.csproj	Links DateTimeOffset/HashCode/Array polyfills for non-`.NETCoreApp`.
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/Base2ExponentialHistogramAggregator.cs	Uses `double.IsFinite` directly; removes local helper.
src/libraries/System.Diagnostics.DiagnosticSource/src/System.Diagnostics.DiagnosticSource.csproj	Links `DoublePolyfills.cs` for non-`.NETCoreApp`.
src/libraries/System.Collections.Immutable/tests/System.Collections.Immutable.Tests.csproj	Replaces product-local polyfills include with linked Common polyfills in tests.
src/libraries/System.Collections.Immutable/src/System/Polyfills.cs	Removes library-local polyfills file.
src/libraries/System.Collections.Immutable/src/System/Collections/Frozen/FrozenHashTable.cs	Uses `Array.MaxLength` unconditionally.
src/libraries/System.Collections.Immutable/src/System.Collections.Immutable.csproj	Removes `System\Polyfills.cs`; links Common polyfills for non-`.NETCoreApp`.
src/libraries/Microsoft.Extensions.Logging.Console/src/SimpleConsoleFormatter.cs	Simplifies conditional `IsAndroidOrAppleMobile` expression body.
src/libraries/Microsoft.Extensions.Logging.Console/src/Microsoft.Extensions.Logging.Console.csproj	Links TextWriter/Encoding polyfills for non-`.NETCoreApp`.
src/libraries/Microsoft.Extensions.Logging.Console/src/JsonConsoleFormatter.cs	Removes unsafe `GetChars` fallback in favor of polyfilled overloads; simplifies char handling.
src/libraries/Microsoft.Extensions.Logging.Console/src/AnsiParsingLogConsole.cs	Uses `TextWriter.Write(ReadOnlySpan<char>)` unconditionally (polyfilled downlevel).
src/libraries/Microsoft.Extensions.Hosting.Systemd/src/SystemdHelpers.cs	Uses `Environment.ProcessId` unconditionally (polyfilled downlevel).
src/libraries/Microsoft.Extensions.Hosting.Systemd/src/Microsoft.Extensions.Hosting.Systemd.csproj	Links `EnvironmentPolyfills.cs` for non-`.NETCoreApp`.
src/libraries/Common/src/Polyfills/TextWriterPolyfills.cs	Adds downlevel `TextWriter.Write(ReadOnlySpan<char>)`.
src/libraries/Common/src/Polyfills/StreamPolyfills.cs	Adds downlevel `Stream.ReadExactly(byte[])` and `CopyToAsync(Stream, CancellationToken)`.
src/libraries/Common/src/Polyfills/StopwatchPolyfills.cs	Adds downlevel `Stopwatch.GetElapsedTime` overloads.
src/libraries/Common/src/Polyfills/SinglePolyfills.cs	Adds downlevel `float.IsFinite`.
src/libraries/Common/src/Polyfills/DoublePolyfills.cs	Adds downlevel `double.IsFinite`.
src/libraries/Common/src/Polyfills/BitArrayPolyfills.cs	Adds downlevel `BitArray.HasAllSet()`.
src/libraries/Common/src/Polyfills/ArrayPolyfills.cs	Adds downlevel `Array.MaxLength`.
src/libraries/Common/src/Polyfills/DateTimeOffsetPolyfills.cs	Adds downlevel `DateTimeOffset.TotalOffsetMinutes`.
src/libraries/Common/src/Polyfills/HashCodePolyfills.cs	Adds downlevel `HashCode.AddBytes(ReadOnlySpan<byte>)` as an extension method.
src/libraries/Common/src/Polyfills/EnvironmentPolyfills.cs	Adds downlevel `Environment.ProcessId`.
src/libraries/Common/src/Polyfills/GuidPolyfills.cs	Adds downlevel `Guid.TryWriteBytes(Span<byte>)`.
src/libraries/Common/src/Polyfills/BitConverterPolyfills.cs	Adds downlevel `BitConverter.SingleToUInt32Bits` / `DoubleToUInt64Bits`.
src/libraries/Common/src/Polyfills/IReadOnlySetPolyfill.cs	Adds downlevel `IReadOnlySet<T>` (guarded by `#if !NET`).
src/libraries/Common/src/Polyfills/BitOperationsPolyfill.cs	Adds downlevel `System.Numerics.BitOperations.RotateLeft` (guarded by `#if !NET`).
src/libraries/Common/src/Polyfills/CollectionsPolyfills.cs	Adds downlevel `KeyValuePair.Deconstruct` extension method.
src/libraries/Common/src/Polyfills/DictionaryPolyfills.cs	Adds downlevel `TryAdd` / `TryDequeue` polyfills (new shared source).

src/libraries/Common/src/Polyfills/EnvironmentPolyfills.cs

Leverage polyfills already in Common/src/Polyfills/ to remove #if NET blocks across additional libraries: - ArrayPolyfills: LengthBuckets.cs, ArrayInfo.cs (Nrbf) - IReadOnlySetPolyfill: ImmutableSortedSet, ImmutableHashSet, FrozenSet - StreamPolyfills: SoundPlayer.cs, XmlBuffer.cs (Syndication) - DateTimeOffsetPolyfills: CacheEntry.cs, Rss20FeedFormatter, Atom10FeedFormatter - HashCodePolyfills: CoseHeaderValue.cs - EnvironmentPolyfills: Win32.cs (Hosting.WindowsServices), SystemdHelpers.cs cleanup Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- EnvironmentPolyfills: dispose Process instance to avoid handle leak - DoublePolyfills/SinglePolyfills: use same bit-manipulation impl as the real Double.IsFinite/Single.IsFinite in CoreLib - IReadOnlySetPolyfill: add comment explaining why #if !NET is needed - StreamPolyfills: add comment explaining the 81_920 buffer size constant Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

New polyfill: RuntimeHelpersPolyfills.cs provides: - TryEnsureSufficientExecutionStack (wraps EnsureSufficientExecutionStack) - GetUninitializedObject (delegates to FormatterServices) Cleaned up in System.Text.Json: - StackHelper.cs: remove #if NET for TryEnsureSufficientExecutionStack - FSharpUnionConverter.cs: remove #if NET for GetUninitializedObject and dead conditional using Skipped (not polyfillable with extension() blocks): - JsonArray.cs: List.AddRange(ReadOnlySpan) and uint.TryFormat - CharConverter.cs: new ReadOnlySpan<char>(in value) constructor - JsonCamelCaseNamingPolicy.cs: string.Create (shared with generators) - JsonReaderHelper.Unescaping.cs: Utf8.IsValid (different error handling) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 66 out of 66 changed files in this pull request and generated 2 comments.

...libraries/Microsoft.Extensions.Caching.Memory/src/Microsoft.Extensions.Caching.Memory.csproj

src/libraries/Microsoft.Extensions.Logging.Console/src/JsonConsoleFormatter.cs

...braries/Microsoft.Extensions.Logging.Console/src/Microsoft.Extensions.Logging.Console.csproj

src/libraries/System.Text.Json/src/System/Text/Json/StackHelper.cs

src/libraries/System.Collections.Immutable/src/System/Polyfills.cs

- Fix stray carriage return in Caching.Memory csproj - JsonConsoleFormatter: use stackalloc span for char writing instead of ToString() to avoid allocation regression (copilot review) - Delete StackHelper.cs, inline RuntimeHelpers.TryEnsureSufficientExecutionStack call directly in JsonElement.cs (jkotas) - Revert IReadOnlySet polyfill: restore #if NET guards on FrozenSet, ImmutableHashSet, ImmutableSortedSet; keep IReadOnlySet<T> definition in library-local Polyfills.cs (jkotas concern about subtle bugs) - Rename BitOperationsPolyfill.cs -> BitOperationsPolyfills.cs for consistent plural naming across all polyfill files - Remove dead StreamPolyfills ref from System.Windows.Extensions (only targets NETCoreApp, polyfill would never compile) - Fix EncodingPolyfills Link path for directory structure consistency Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- Fully revert all changes to SimpleConsoleFormatter.cs - JsonConsoleFormatter: use [charValue] collection literal instead of stackalloc + manual assignment Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 61 out of 61 changed files in this pull request and generated no new comments.

The Libraries_NET481 CI leg fails because extension() blocks on primitive types may not resolve correctly under the VS MSBuild toolchain. Restore the original #if NET / #else pattern for Base2ExponentialHistogramAggregator.IsFinite. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

src/libraries/Common/src/Polyfills/BitOperationsPolyfills.cs

src/libraries/Common/src/Polyfills/CollectionsPolyfills.cs

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

…into common-pollyfills

Copilot

Pull request overview

Copilot reviewed 59 out of 59 changed files in this pull request and generated 6 comments.

src/libraries/Common/src/Polyfills/StopwatchPolyfills.cs

src/libraries/Common/src/Polyfills/RuntimeHelpersPolyfills.cs

src/libraries/Common/src/Polyfills/CollectionsPolyfills.cs

src/libraries/Common/src/Polyfills/DictionaryPolyfills.cs

- StopwatchPolyfills.cs: add missing 'using System' for TimeSpan - RuntimeHelpersPolyfills.cs: add missing 'using System' for Type - CollectionsPolyfills.cs: remove unused 'using System.ComponentModel' - Delete DictionaryPolyfills.cs: unreferenced dead code, duplicates test DictionaryExtensions.cs, Queue polyfill misplaced (jkotas) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

jkotas · 2026-03-30T16:44:40Z

remove dead DictionaryPolyfills

Would it make more sense to delete src\libraries\Common\tests\System\Collections\DictionaryExtensions.cs and move the polyfill implementation into the Polyfill directory?

jkotas · 2026-03-30T16:48:28Z

Revert DiagnosticSource polyfill change (net481 CI uses VS MSBuild)

What's the problem with this? Why is use of polyfills conflicting with VS MSBuild?

EgorBo · 2026-03-30T16:48:29Z

remove dead DictionaryPolyfills

Would it make more sense to delete src\libraries\Common\tests\System\Collections\DictionaryExtensions.cs and move the polyfill implementation into the Polyfill directory?

Sure, will do. This PR doesn't move all of them; there are still tons of in-place polyfills we can move there (some of them are quite complex) - definitely too many for a single PR to handle. My main motivation is to be able to move unsafe code under the rug and out of libraries due to the lack of safe APIs in old targets

…lls.cs Per jkotas feedback: move the TryAdd polyfill from Common/tests/ to Common/src/Polyfills/ so it lives alongside other polyfills. Update all 5 test projects that referenced the old file. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 63 out of 63 changed files in this pull request and generated 1 comment.

src/libraries/Common/src/Polyfills/EnvironmentPolyfills.cs

…lyfill Convert all src/libraries/Common/src/Polyfills/*.cs to file-scoped namespace declarations. Restore DoublePolyfills usage in Base2ExponentialHistogramAggregator (revert the revert). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-03-30T21:49:51Z

🤖 Copilot Code Review — PR #126287

Note

This review was generated by GitHub Copilot.

Holistic Assessment

Motivation: Justified. Duplicate #if NET/#else polyfill blocks are scattered across ~30 library files, creating real maintenance burden and inconsistency risk. Centralizing them is a clear win.

Approach: Sound. Moving polyfills to Common/src/Polyfills/ with csproj-level conditional includes is the established pattern in this repository. The use of C# extension(...) blocks for API shims ensures the compiler naturally prefers real APIs on .NETCoreApp, making the conditional includes safe and the source code cleaner.

Summary: ✅ LGTM. The refactoring is mechanically correct, all source-project csproj conditions are properly guarded ('$(TargetFrameworkIdentifier)' != '.NETCoreApp'), no new public API surface is introduced, review feedback from jkotas (IReadOnlySet revert, StackHelper deletion) has been incorporated, and unsafe usage is properly enabled in consuming projects. One minor style issue flagged below.

Detailed Findings

✅ Correctness — csproj conditional includes are all correct

Verified every source-project polyfill include. All are inside ItemGroup Condition="'$(TargetFrameworkIdentifier)' != '.NETCoreApp'" (or equivalent version-bounded conditions for DiagnosticSource). This ensures polyfills are only compiled for downlevel TFMs and avoids conflicts with real APIs (especially important for BitOperationsPolyfills.cs which defines System.Numerics.BitOperations directly, not as an extension block).

Test projects (Common.Tests.csproj, System.Linq.Expressions.Tests.csproj, XML Linq tests) include DictionaryPolyfills.cs unconditionally, matching the previous DictionaryExtensions.cs behavior. Since TryAdd is an extension on IDictionary<TKey,TValue>, instance method resolution on Dictionary<TKey,TValue> takes precedence on .NETCoreApp — no conflict.

✅ Correctness — Code transformations are mechanically faithful

Spot-checked all major replacements:

JsonHelpers.IsFinite(double/float) → double.IsFinite()/float.IsFinite() — polyfill provides these on downlevel via extension(double/float) ✓
StackHelper.TryEnsureSufficientExecutionStack() → RuntimeHelpers.TryEnsureSufficientExecutionStack() — polyfill wraps EnsureSufficientExecutionStack in try/catch on downlevel ✓
FormatterServices.GetUninitializedObject → RuntimeHelpers.GetUninitializedObject — polyfill delegates to FormatterServices with SYSLIB0050 suppression ✓
Inline Stream.ReadExactly loops → stream.ReadExactly() — polyfill provides equivalent loop ✓
Stopwatch.GetElapsedTime and DateTimeOffset.TotalOffsetMinutes replacements — polyfills match original inline implementations ✓
Array.MaxLength constant 0x7FFFFFC7 → Array.MaxLength property — polyfill exposes same value via extension(Array) ✓
JsonConsoleFormatter char writing: MemoryMarshal.CreateSpan(ref charValue, 1) → [charValue] collection expression — allocation-free ReadOnlySpan<char>, nice simplification ✓

✅ Correctness — Unsafe code properly enabled

SinglePolyfills.cs uses unsafe pointer casts. Verified that all consuming projects (System.Text.Json, System.Collections.Immutable) have <AllowUnsafeBlocks>true</AllowUnsafeBlocks>.

✅ Dead code cleanup

StackHelper.cs, System.Reflection.Metadata/Polyfills.cs, inline #if NET/#else blocks, and unused using directives (e.g., System.Runtime.InteropServices from JsonConsoleFormatter.cs, System.Runtime.Serialization from FSharpUnionConverter.cs) are all properly removed.

💡 Missing trailing newlines on all 16 new polyfill files

All files in Common/src/Polyfills/ are missing a final newline (\ No newline at end of file in the diff). The repo's .editorconfig specifies insert_final_newline = true for [*]. This should be a quick fix to add a trailing newline to each file.

Generated by Code Review for issue #126287 · ◷

EgorBo and others added 5 commits March 30, 2026 02:49

move all pollyfills to a common folder

a5b5bbc

Merge remote-tracking branch 'origin/main' into common-pollyfills

8fbba08

Move Reflection.Metadata Polyfills.cs to Common/src/Polyfills/

f5429ba

Split into BitConverterPolyfills.cs and GuidPolyfills.cs for reuse across libraries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 30, 2026 01:54

github-actions bot added the area-Meta label Mar 30, 2026

dotnet-policy-service bot assigned EgorBo Mar 30, 2026

Copilot started reviewing on behalf of EgorBo March 30, 2026 01:55 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

src/libraries/Common/src/Polyfills/EnvironmentPolyfills.cs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Copilot AI review requested due to automatic review settings March 30, 2026 02:49

Copilot started reviewing on behalf of EgorBo March 30, 2026 02:50 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

...libraries/Microsoft.Extensions.Caching.Memory/src/Microsoft.Extensions.Caching.Memory.csproj Outdated Show resolved Hide resolved

src/libraries/Microsoft.Extensions.Logging.Console/src/JsonConsoleFormatter.cs Outdated Show resolved Hide resolved

jkotas reviewed Mar 30, 2026

View reviewed changes

...braries/Microsoft.Extensions.Logging.Console/src/Microsoft.Extensions.Logging.Console.csproj Outdated Show resolved Hide resolved

jkotas reviewed Mar 30, 2026

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/StackHelper.cs Outdated Show resolved Hide resolved

jkotas reviewed Mar 30, 2026

View reviewed changes

src/libraries/System.Collections.Immutable/src/System/Polyfills.cs Show resolved Hide resolved

This comment has been minimized.

Sign in to view

This was referenced Mar 30, 2026

Unable to pull image from mcr.microsoft.com #117164

Open

XHarness package install failure on iOS due to devicectl NSPOSIXErrorDomain error 49 #123796

Open

This comment has been minimized.

Sign in to view

Copilot AI review requested due to automatic review settings March 30, 2026 14:36

Copilot started reviewing on behalf of EgorBo March 30, 2026 14:37 View session

EgorBo marked this pull request as ready for review March 30, 2026 14:40

This comment has been minimized.

Sign in to view

Copilot AI reviewed Mar 30, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

jkotas reviewed Mar 30, 2026

View reviewed changes

src/libraries/Common/src/Polyfills/BitOperationsPolyfills.cs Outdated Show resolved Hide resolved

jkotas reviewed Mar 30, 2026

View reviewed changes

src/libraries/Common/src/Polyfills/CollectionsPolyfills.cs Outdated Show resolved Hide resolved

EgorBo and others added 3 commits March 30, 2026 18:02

Merge remote-tracking branch 'origin/main' into common-pollyfills

4e9206c

FB

ea731b6

Update src/libraries/Common/src/Polyfills/CollectionsPolyfills.cs

922b086

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Copilot AI review requested due to automatic review settings March 30, 2026 16:09

Merge branch 'common-pollyfills' of https://github.com/dotnet/runtime …

313d26d

…into common-pollyfills

Copilot started reviewing on behalf of EgorBo March 30, 2026 16:10 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

jkotas reviewed Mar 30, 2026

View reviewed changes

src/libraries/Common/src/Polyfills/DictionaryPolyfills.cs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

jkotas reviewed Mar 30, 2026

View reviewed changes

src/libraries/Common/src/Polyfills/DictionaryPolyfills.cs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Copilot AI review requested due to automatic review settings March 30, 2026 16:52

Copilot started reviewing on behalf of EgorBo March 30, 2026 16:53 View session

This comment has been minimized.

Sign in to view

Copilot AI reviewed Mar 30, 2026

View reviewed changes

src/libraries/Common/src/Polyfills/EnvironmentPolyfills.cs Outdated Show resolved Hide resolved

jkotas approved these changes Mar 30, 2026

View reviewed changes

Conversation

EgorBo commented Mar 30, 2026

Uh oh!

dotnet-policy-service bot commented Mar 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

jkotas commented Mar 30, 2026

Uh oh!

jkotas commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

EgorBo commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

github-actions bot commented Mar 30, 2026

🤖 Copilot Code Review — PR #126287

Holistic Assessment

Detailed Findings

✅ Correctness — csproj conditional includes are all correct

✅ Correctness — Code transformations are mechanically faithful

✅ Correctness — Unsafe code properly enabled

✅ Dead code cleanup

💡 Missing trailing newlines on all 16 new polyfill files

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jkotas commented Mar 30, 2026 •

edited

Loading

EgorBo commented Mar 30, 2026 •

edited

Loading