Handle stopped main event loops in async_to_sync#558
Open
davitacols wants to merge 1 commit intodjango:mainfrom
Open
Handle stopped main event loops in async_to_sync#558davitacols wants to merge 1 commit intodjango:mainfrom
davitacols wants to merge 1 commit intodjango:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main_event_loopwhen it is still runningA stopped loop can still accept
call_soon_threadsafe()without ever running the scheduled task, which leavesasync_to_sync()blocked waiting for a result.Fixes #545.
Testing
python -m pytest -qpython -m mypy asgiref tests setup.py docs/conf.py