fix(#2608): auto-detect digger-os and digger-arch inputs in github ac…#2626
Open
Mallikarjunadevops wants to merge 1 commit intodiggerhq:developfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Resolves #2608.
Currently,
action.ymlhardcodes its inputs to default toLinuxandX64. When users run Digger on non-x86 Linux machines or macOS self-hosted runners (Apple Silicon), the CLI download step fails because it blindly requests the legacyLinux-X64binary payload without accounting for the actual runner architecture.This Pull Request introduces auto-detection functionality that gracefully falls back to the native
runner.osandrunner.archmetrics exclusively when thedigger-osordigger-archinputs are omitted.How
action.ymlto set the default value of the OS and Architecture inputs to an empty string"".name: download, install, and run diggerstep.runner.os(Linux, macOS, Windows) andrunner.arch(X64, ARM64, etc.) outputs into their corresponding Golang static binary compilation identifiers (linux,darwin,amd64,arm64, etc.).-zempty-string checks; if a user continues explicitly providing properties to thewith:segment on old configurations, auto-detection gracefully yields control.Testing
Disclosure: I consulted with an AI assistant while writing the implementation for this auto-detect feature.
reviewed and verified manually._