fix: show errors on auth fail and save tokens only on success#700
Open
Z1xus wants to merge 1 commit intoayn2op:mainfrom
Open
fix: show errors on auth fail and save tokens only on success#700Z1xus wants to merge 1 commit intoayn2op:mainfrom
Z1xus wants to merge 1 commit intoayn2op:mainfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
le problema: previously, discordo would try to authenticate via showChatView before calling a.inner.Run(). if the provided token was incorrect, the function would return an error and exit immediately
because a.inner.Run() was never reached, tview never took control of the terminal's lifecycle, so its cleanup logic was never triggered. this left the user's terminal stuck in reporting mode, leaking ansi escape codes (like sgr mouse tracking)
also, while at it, i noticed that invalid tokens were being saved to the keyring regardless of whether the auth returned success, causing the app to repeat the same error on every restart. errors were also not being shown to the user
fix:
closes issue: #685