Open
Conversation
| root := gt.GetRoot() | ||
|
|
||
| var guildNode *tview.TreeNode | ||
| foundGuild := false |
Contributor
There was a problem hiding this comment.
Redundant: you can just check if guildNode != nil for foundGuild.
Comment on lines
+232
to
+235
| // it continues walking without this | ||
| if foundGuild { | ||
| return false | ||
| } |
Contributor
There was a problem hiding this comment.
Redundant: since you are already returning false when a guild a found, so the Walk func returns early anyway.
Comment on lines
+236
to
+243
| if guildID, ok := node.GetReference().(discord.GuildID); ok { | ||
| indication := discordState.GuildIsUnread(guildID, ningen.GuildUnreadOpts{UnreadOpts: ningen.UnreadOpts{IncludeMutedCategories: true}}) | ||
| if indication == ningen.ChannelMentioned || indication == ningen.ChannelUnread { | ||
| guildNode = node | ||
| foundGuild = true | ||
| return false | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
This only handles guilds, not private channels (DMs), check state.go:80 for example:
switch node.GetReference() {
case event.GuildID:
node.SetTextStyle(app.chatView.guildsTree.getGuildNodeStyle(event.GuildID))
guildNode = node
return false
case event.ChannelID:
// private channel
if !event.GuildID.IsValid() {
style := app.chatView.guildsTree.getChannelNodeStyle(event.ChannelID)
node.SetTextStyle(style)
return false
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
selects the first unread channel and expands the guild if necessary with shortcut
u(aka unread) while selected the guild tree.Closes #664