fix: create sticky comment in agent mode when useStickyComment is enabled#1120
Open
majiayu000 wants to merge 1 commit intoanthropics:mainfrom
Open
fix: create sticky comment in agent mode when useStickyComment is enabled#1120majiayu000 wants to merge 1 commit intoanthropics:mainfrom
majiayu000 wants to merge 1 commit intoanthropics:mainfrom
Conversation
…bled When useStickyComment is true and the context is entity-based (PR/issue), agent mode now creates an initial tracking comment and passes the comment ID to the MCP config. Previously, claudeCommentId was hardcoded to undefined, causing the MCP server to start without CLAUDE_COMMENT_ID. Signed-off-by: majiayu000 <1835304752@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1108
Summary
claudeCommentIdwas hardcoded toundefinedinprepareAgentMode, so the MCP comment server never receivedCLAUDE_COMMENT_IDeven whenuse_sticky_commentwas enabled.createInitialCommentcall that tag mode uses: whenuseStickyCommentistrueand the context is entity-based (PR/issue), it creates the initial comment and passes the ID toprepareMcpConfig.workflow_dispatch,schedule) with no entity skip comment creation gracefully.Test plan
createInitialCommentis called whenuseStickyComment=truewith entity context, and that the returnedcommentIdis passed through to the result and MCP config.createInitialCommentis NOT called for automation contexts or whenuseStickyComment=false.bun test(654 pass),bun run typecheck,bun run format:checkall pass.