Skip to content

imnodes: unstable-2024-03-12 -> unstable-2025-06-25#505138

Open
jemand771 wants to merge 1 commit intoNixOS:masterfrom
jemand771:imnodes-unstable-2025-06-25
Open

imnodes: unstable-2024-03-12 -> unstable-2025-06-25#505138
jemand771 wants to merge 1 commit intoNixOS:masterfrom
jemand771:imnodes-unstable-2025-06-25

Conversation

@jemand771
Copy link
Copy Markdown
Member

No changelog as this is still not a real version but just grab-master-and-slap-a-date-on-it
Diff (tiny): https://github.com/Nelarius/imnodes/compare/8563e1655bd9bb1f249e6552cc6274d506ee788b..b2ec254ce576ac3d42dfb7aef61deadbff8e7211

A note on `imnodes.passthru.tests`:

passthru.tests.examples = imnodes.override { withExamples = true; };

results in

/build/source/example/main.cpp:4:10: fatal error: imgui_impl_sdl2.h: No such file or directory
    4 | #include <imgui_impl_sdl2.h>

So, you'd need to switch from imgui as a dependency to imgui.override { IMGUI_BUILD_SDL2_BINDING = true; }, only to discover

meta = {
# These flags haven't been tested:
broken =
IMGUI_BUILD_SDL2_BINDING # Option removed from Vcpkg' CMakeLists
|| IMGUI_BUILD_SDL2_RENDERER_BINDING
|| IMGUI_FREETYPE
|| IMGUI_FREETYPE_LUNASVG
|| IMGUI_BUILD_DX9_BINDING
|| IMGUI_BUILD_DX10_BINDING
|| IMGUI_BUILD_DX11_BINDING
|| IMGUI_BUILD_DX12_BINDING
|| IMGUI_BUILD_WIN32_BINDING
|| IMGUI_BUILD_ALLEGRO5_BINDING
|| IMGUI_BUILD_ANDROID_BINDING;

And I really don't feel like getting into that right now. The tests were broken before, they're still broken, and not relevant to this update (look at the upstream diff)

Maintainer ping: @SomeoneSerge

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@jemand771 jemand771 marked this pull request as ready for review March 30, 2026 23:49
@jemand771 jemand771 mentioned this pull request Mar 30, 2026
13 tasks
@nixpkgs-ci nixpkgs-ci bot requested a review from SomeoneSerge March 30, 2026 23:54
@nixpkgs-ci nixpkgs-ci bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant