imnodes: unstable-2024-03-12 -> unstable-2025-06-25#505138
Open
jemand771 wants to merge 1 commit intoNixOS:masterfrom
Open
imnodes: unstable-2024-03-12 -> unstable-2025-06-25#505138jemand771 wants to merge 1 commit intoNixOS:masterfrom
jemand771 wants to merge 1 commit intoNixOS:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No changelog as this is still not a real version but just grab-master-and-slap-a-date-on-it
Diff (tiny): https://github.com/Nelarius/imnodes/compare/8563e1655bd9bb1f249e6552cc6274d506ee788b..b2ec254ce576ac3d42dfb7aef61deadbff8e7211
A note on `imnodes.passthru.tests`:
nixpkgs/pkgs/by-name/im/imnodes/package.nix
Line 47 in 05cc617
results in
So, you'd need to switch from
imguias a dependency toimgui.override { IMGUI_BUILD_SDL2_BINDING = true; }, only to discovernixpkgs/pkgs/by-name/im/imgui/package.nix
Lines 139 to 152 in 1a99461
And I really don't feel like getting into that right now. The tests were broken before, they're still broken, and not relevant to this update (look at the upstream diff)
Maintainer ping: @SomeoneSerge
Things done
passthru.tests. <- brokennixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.