Skip to content

nixVersions.stable: 2.31.3 -> 2.34.4#505121

Open
philiptaron wants to merge 4 commits intoNixOS:staging-nixosfrom
philiptaron:nix-stable-bump
Open

nixVersions.stable: 2.31.3 -> 2.34.4#505121
philiptaron wants to merge 4 commits intoNixOS:staging-nixosfrom
philiptaron:nix-stable-bump

Conversation

@philiptaron
Copy link
Copy Markdown
Contributor

@philiptaron philiptaron commented Mar 30, 2026

It's time to do it. 26.05 awaits. CI has been building with these quite successfully.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@philiptaron philiptaron requested a review from xokdvium March 30, 2026 22:13
@philiptaron philiptaron changed the base branch from master to staging-nixos March 30, 2026 22:13
@nixpkgs-ci nixpkgs-ci bot closed this Mar 30, 2026
@nixpkgs-ci nixpkgs-ci bot reopened this Mar 30, 2026
xokdvium
xokdvium reviewed Mar 30, 2026
View reviewed changes
pkgs/by-name/sy/system-manager/package.nix Outdated
Comment on lines +45 to +47
# Nix needs a writable home for its cache directory (~/.cache/nix).
export HOME=$TMPDIR/home
mkdir -p "$HOME"
Copy link
Copy Markdown
Contributor

@xokdvium xokdvium Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use writableTmpDirAsHomeHook for this? I'm pretty sure this won't build without a sandbox.

@nixpkgs-ci nixpkgs-ci bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 30, 2026
xokdvium
xokdvium reviewed Mar 30, 2026
View reviewed changes
pkgs/by-name/ll/llhttp/package.nix Outdated
Comment on lines +34 to +35
(lib.cmakeBool "BUILD_SHARED_LIBS" (!stdenv.hostPlatform.isStatic))
(lib.cmakeBool "BUILD_STATIC_LIBS" stdenv.hostPlatform.isStatic)
(lib.cmakeBool "LLHTTP_BUILD_SHARED_LIBS" (!stdenv.hostPlatform.isStatic))
(lib.cmakeBool "LLHTTP_BUILD_STATIC_LIBS" stdenv.hostPlatform.isStatic)
Copy link
Copy Markdown
Contributor

@xokdvium xokdvium Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably go to staging, right? No reason to block the nix bump on the huge amount of rebuilds here.

Copy link
Copy Markdown
Contributor Author

@philiptaron philiptaron Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I didn't realize the shear number of these.

Copy link
Copy Markdown
Contributor Author

@philiptaron philiptaron Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#505134

@philiptaron philiptaron mentioned this pull request Mar 30, 2026
Closed
13 tasks
@philiptaron
nix-scheduler-hook: pin to nix 2.31
80b678d 
nix-scheduler-hook doesn't build against nix >= 2.32 due to C++ API
changes (Realisation/UnkeyedRealisation type split, nix::Path removal,
parseStorePathSet signature change). Pin to nix_2_31 until upstream
adapts.
@philiptaron
system-manager: fix test sandbox failure with newer nix
b928745 
Nix now requires a writable home directory for its cache
(~/.cache/nix). Set HOME to a writable tmpdir so that
test_try_nix_eval passes in the build sandbox.
@philiptaron
nix: fix nix-store-tests-run for static builds
869ca79 
The test runner's buildInputs (writableTmpDirAsHomeHook, openssl)
need to be nativeBuildInputs. In the static (cross-musl) build,
strictDeps is enabled and only nativeBuildInputs are added to PATH.
With buildInputs, openssl was not in PATH, causing
HttpsBinaryCacheStoreTest.queryPathInfo to crash.
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches. and removed 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Mar 30, 2026
@philiptaron
Copy link
Copy Markdown
Contributor Author

philiptaron commented Mar 30, 2026

That's a better number of rebuilds.

@philiptaron philiptaron marked this pull request as ready for review March 30, 2026 23:50
@nixpkgs-ci nixpkgs-ci bot requested review from Artturin and Ericson2314 March 30, 2026 23:52
lisanna-dettwyler
lisanna-dettwyler reviewed Mar 31, 2026
View reviewed changes
pkgs/by-name/ni/nix-scheduler-hook/package.nix
Copy link
Copy Markdown
Contributor

@lisanna-dettwyler lisanna-dettwyler Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Artturin Artturin Awaiting requested review from Artturin

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@jfroche jfroche Awaiting requested review from jfroche

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

@Mic92 Mic92 Awaiting requested review from Mic92

@picnoir picnoir Awaiting requested review from picnoir

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

@roberth roberth Awaiting requested review from roberth

@tomberek tomberek Awaiting requested review from tomberek

2 more reviewers

@lisanna-dettwyler lisanna-dettwyler lisanna-dettwyler left review comments

@xokdvium xokdvium xokdvium left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@philiptaron @lisanna-dettwyler @xokdvium