Sync clear text after ctrl backspace#1652
Open
Riteshchaudhary710 wants to merge 1 commit intoAlex-D:developfrom
Open
Sync clear text after ctrl backspace#1652Riteshchaudhary710 wants to merge 1 commit intoAlex-D:developfrom
Riteshchaudhary710 wants to merge 1 commit intoAlex-D:developfrom
Conversation
Author
|
cc @Alex-D Could you please review this pr? |
Owner
|
Code looks good, but I don't understand why we need to add something that specific. Since we sync on each keydown, I think we have something wrong on that side... |
Author
|
I encountered a strange issue when clearing text using Ctrl + Backspace. Although the text appears to be cleared, it reappears in the rendered content after clicking the submit button. Screencast.from.10-2-26.04.27.21.+0545.webmcc @Alex-D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1651
This pull request introduces an improvement to the keyboard event handling logic in
src/trumbowyg.js. Specifically, it ensures that when a user uses Ctrl + Backspace (or Cmd + Backspace on Mac) to clear text, the editor correctly synchronizes the underlying textarea to reflect the change.Keyboard event handling improvement:
syncTextarea()after the event, ensuring the editor's state stays in sync with the textarea when text is cleared using this shortcut.