Honor stderrthreshold when logtostderr is enabled#1822
Honor stderrthreshold when logtostderr is enabled#1822k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
Conversation
|
Skipping CI for Draft Pull Request. |
Update k8s.io/klog/v2 from v2.130.1 to v2.140.0 and opt into the new behavior where -stderrthreshold is honored even when -logtostderr=true. Previously, with the default -logtostderr=true, the -stderrthreshold flag was completely ignored and all log levels went to stderr. klog v2.140.0 (kubernetes/klog#432) added a new opt-in flag -legacy_stderr_threshold_behavior that, when set to false, makes -stderrthreshold work as expected. Set -stderrthreshold=INFO to preserve backward-compatible behavior. Users can now override it to WARNING or ERROR to reduce stderr noise. Fixes kubernetes-sigs#128 Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@gmail.com>
41b1587 to
8161ba0
Compare
|
/test all |
|
cc @leakingtapan @mskanth972 — would you be able to review this when you get a chance? This opts into the klog fix for kubernetes/klog#212 so that |
|
Gentle ping @leakingtapan @mskanth972 — would you be able to review when you get a chance? This is a one-line fix for kubernetes/klog#432. Thank you! |
|
I did e2e tests from my end and verified that if we set
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DavidXU12345, pierluigilenoci The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
k8s.io/klog/v2to v2.140.0 which includes the fix for kubernetes/klog#212-legacy_stderr_threshold_behavior=false-stderrthreshold=INFOto preserve backward-compatible behavior-stderrthresholdtoWARNINGorERRORto reduce stderr noiseFixes #128
Ref: kubernetes/klog#212, kubernetes/klog#432